-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[Core] Fix the race condition where grpc requests are handled while core worker not yet initialized" #37343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Jul 12, 2023
rickyyx
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scv119
added a commit
to scv119/ray
that referenced
this pull request
Jul 12, 2023
… handled while core worker not yet initialized (ray-project#37117)" (ray-project#37343)" This reverts commit 59a15fc.
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
Jul 18, 2023
… handled while core worker not yet initialized (ray-project#37117)" (ray-project#37343)" This reverts commit 59a15fc.
8 tasks
scv119
pushed a commit
that referenced
this pull request
Jul 18, 2023
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 28, 2023
… while core worker not yet initialized (ray-project#37117)" (ray-project#37343) This reverts commit 5e8fd37.
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 28, 2023
… handled while core worker not yet initialized (ray-project#37117)" (ray-project#37343)" (ray-project#37495) This reverts commit 59a15fc.
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
… while core worker not yet initialized (ray-project#37117)" (ray-project#37343) This reverts commit 5e8fd37. Signed-off-by: NripeshN <nn2012@hw.ac.uk>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
… handled while core worker not yet initialized (ray-project#37117)" (ray-project#37343)" (ray-project#37495) This reverts commit 59a15fc. Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
… while core worker not yet initialized (ray-project#37117)" (ray-project#37343) This reverts commit 5e8fd37. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
… handled while core worker not yet initialized (ray-project#37117)" (ray-project#37343)" (ray-project#37495) This reverts commit 59a15fc. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
… handled while core worker not yet initialized (ray-project#37117)" (ray-project#37343)" (ray-project#37495) This reverts commit 59a15fc. Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #37117
Seems it causing other issues in release tests.