Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Cherry-pick #37119 #37263

Merged
merged 1 commit into from
Jul 12, 2023
Merged

[Data] Cherry-pick #37119 #37263

merged 1 commit into from
Jul 12, 2023

Conversation

scottjlee
Copy link
Contributor

@scottjlee scottjlee commented Jul 10, 2023 •
edited
Loading

Why are these changes needed?

This PR cherry picks #37119 into Ray 2.6.0, which corrects a bug in calculating stage execution times in DatasetStats.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scottjlee
[Data] Calculate stage execution time in StageStatsSummary from `Bl…
b38603f 
…ockMetadata` (ray-project#37119)

Currently, the stage execution time used in `StageStatsSummary` is the Dataset's total execution time: https://github.com/ray-project/ray/blob/master/python/ray/data/_internal/stats.py#L292

Instead, we should calculate the execution time as the maximum wall time from the stage's `BlockMetadata`, so that this output is correct in cases with multiple stages.

Signed-off-by: Scott Lee <sjl@anyscale.com>
@scottjlee scottjlee changed the base branch from master to releases/2.6.0 July 10, 2023 19:11
@scottjlee scottjlee added release-blocker P0 Issue that blocks the release v2.6.0-pick labels Jul 10, 2023
@scottjlee scottjlee marked this pull request as ready for review July 11, 2023 00:29
c21
c21 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM to cherry pick. cc @zhe-thoughts.

@bveeramani bveeramani merged commit 45d7d68 into ray-project:releases/2.6.0 Jul 12, 2023
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c21 c21 c21 approved these changes

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

Assignees

@c21 c21

@zhe-thoughts zhe-thoughts

Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottjlee @c21 @zhe-thoughts @bveeramani