[Logging] Switch worker_setup_hook to worker_process_setup_hook #37247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
jjyao
approved these changes
Jul 12, 2023
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
angelinalg
approved these changes
Jul 14, 2023
| This is an experimental feature. The semantic of the API is subject to change. | ||
| It doesn't support [Ray Client](ray-client-ref) yet. | ||
|
|
||
| When you use `ray.init(runtime_env={...})` with a [Ray Job Submission](jobs-quickstart) API (`ray job subimt --working-dir` or `ray job submit --runtime-env ...`), runtime_env passed to `ray.init` is ignored. |
There was a problem hiding this comment.
Suggested change
| When you use `ray.init(runtime_env={...})` with a [Ray Job Submission](jobs-quickstart) API (`ray job subimt --working-dir` or `ray job submit --runtime-env ...`), runtime_env passed to `ray.init` is ignored. | |
| When you use `ray.init(runtime_env={...})` with a [Ray Job Submission](jobs-quickstart) API (`ray job submit --working-dir` or `ray job submit --runtime-env ...`), runtime_env passed to `ray.init` is ignored. |
There was a problem hiding this comment.
This is hard to parse. Are you saying that these two switches don't work when you just Ray Jobs?
There was a problem hiding this comment.
ray job ... is a job API. When you use the job API, the driver runtime env is ignored.
There was a problem hiding this comment.
Any recommended sentences?
There was a problem hiding this comment.
I changed it. Can you take a look? If there's no response by today, I will just merge a PR!
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
Jul 17, 2023
…project#37247) Change worker_setup_hook -> worker_process_setup_hook Signed-off-by: SangBin Cho <rkooo567@gmail.com>
bveeramani
pushed a commit
that referenced
this pull request
Jul 17, 2023
…) (#37463) Change worker_setup_hook -> worker_process_setup_hook Signed-off-by: SangBin Cho <rkooo567@gmail.com>
8 tasks
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 28, 2023
…project#37247) Change worker_setup_hook -> worker_process_setup_hook
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…project#37247) Change worker_setup_hook -> worker_process_setup_hook Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…project#37247) Change worker_setup_hook -> worker_process_setup_hook Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…project#37247) Change worker_setup_hook -> worker_process_setup_hook Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Change worker_setup_hook -> worker_process_setup_hook
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.