[core][autoscaler] Fix pg id serialization with hex rather than binary for cluster state reporting #37132 #37176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y for cluster state reporting ray-project#37132 Why are these changes needed? The labels are declared as strings, and PG will generate (anti)affinity labels. The current implementation geneates _PG_<binary_pg_id> as the label key. However, binary chars are not encodable in string. This PR changes the pg generated dynamic labels to _PG_<hex_pg_id> which is more readable as well.
|
For autoscaler v2. |
zhe-thoughts
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The labels are declared as strings, and PG will generate (anti)affinity labels. The current implementation geneates PG<binary_pg_id> as the label key. However, binary chars are not encodable in string.
This PR changes the pg generated dynamic labels to PG<hex_pg_id> which is more readable as well.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.