[core][logging][ipython] Fix log buffering when consecutive runs within ray log dedup window #37134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Fixes #34831
The issue is when tasks runs within the same job are executed and producing logs, log lines will be dedup for better observability.
So ray might be buffering some lines, in case there are logs that could be dedup within the same
RAY_DEDUP_LOGS_AGG_WINDOW_S
. This will show up as logs line not available until future ray tasks runs since buffer is not flushed when there's no activity (no job done, no new task)This PR adds callbacks to the
post_execute
to flush the log lines in log monitor when execution in shell took place.Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.