Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][core] Add metrics for object size distribution in object store (#37005) #37110

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

fishbone
Copy link
Contributor

@fishbone fishbone commented Jul 5, 2023

Why are these changes needed?

This PR add the metrics for the object size distribution to help the user understand how the objects are used in the script.

Related issue number

#36923

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…project#37005)

## Why are these changes needed?
This PR add the metrics for the object size distribution to help the user understand how the objects are used in the script.

## Related issue number
ray-project#36923
@fishbone fishbone added release-blocker P0 Issue that blocks the release v2.6.0-pick labels Jul 5, 2023
@fishbone fishbone requested a review from a team as a code owner July 5, 2023 18:15
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be clean change. Let's pick

@bveeramani bveeramani merged commit 3259647 into ray-project:releases/2.6.0 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants