Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[air/release] Fix batch format in dreambooth example #37102

Merged
merged 6 commits into from
Jul 6, 2023
Merged

[air/release] Fix batch format in dreambooth example #37102

merged 6 commits into from
Jul 6, 2023

Conversation

justinvyu
Copy link
Contributor

Why are these changes needed?

This fixes an error caused by the default batch format of Ray Data changing to numpy. We need to manually specify pandas.

Related issue number

Closes #36536

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

justinvyu added 2 commits June 27, 2023 18:40
@justinvyu
Fix batch format
abacc3c 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into rele…
ca6479a 
…ase/fix_dreambooth_example
@justinvyu justinvyu requested a review from krfricke July 5, 2023 17:16
@pcmoritz
Copy link
Contributor

pcmoritz commented Jul 5, 2023

Thanks for fixing this, we should also make sure to pick this into Ray 2.6 @zhe-thoughts :)

justinvyu added 2 commits July 5, 2023 18:23
@justinvyu
Fix the dependency installs
b3f0499 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into rele…
713b474 
…ase/fix_dreambooth_example
@justinvyu justinvyu added the release-test release test label Jul 6, 2023
justinvyu added 2 commits July 5, 2023 22:37
@justinvyu
Use a valid cluster env
94aecb7 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into rele…
bc74742 
…ase/fix_dreambooth_example
@justinvyu justinvyu added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jul 6, 2023
@justinvyu justinvyu requested a review from krfricke July 6, 2023 07:47
krfricke
krfricke approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krfricke krfricke merged commit e876693 into ray-project:master Jul 6, 2023
@justinvyu justinvyu deleted the release/fix_dreambooth_example branch July 6, 2023 19:51
@zhe-thoughts
Copy link
Collaborator

@justinvyu great work. Once there's a cherry pick PR please assign to me. Thanks

justinvyu added a commit to justinvyu/ray that referenced this pull request Jul 7, 2023
@justinvyu
[air/release] Fix batch format in dreambooth example (ray-project#3…
cf2e646 
…7102)

This fixes an error caused by the default batch format of Ray Data changing to numpy. We need to manually specify pandas.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu mentioned this pull request Jul 7, 2023
Merged
8 tasks
bveeramani pushed a commit that referenced this pull request Jul 7, 2023
@justinvyu
[air/release] Fix batch format in dreambooth example (#37102) (#37189)
47ec25b 
This fixes an error caused by the default batch format of Ray Data changing to numpy. We need to manually specify pandas.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@justinvyu @arvind-chandra
[air/release] Fix batch format in dreambooth example (ray-project#3…
da82386 
…7102)

This fixes an error caused by the default batch format of Ray Data changing to numpy. We need to manually specify pandas.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

Assignees

@krfricke krfricke

Labels
release-test release test tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release test air_example_dreambooth_finetuning failed
4 participants
@justinvyu @pcmoritz @zhe-thoughts @krfricke