[Serve] Use serve_instance for test_http_headers to reduce the test time #36988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
|
oh, acutally, it was slow because I use |
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
sihanwang41
commented
Jun 30, 2023
|
|
||
| if deploy_type == "fastapi": | ||
| app = FastAPI() | ||
| class TestUserProvidedRequestIDHeader: |
There was a problem hiding this comment.
No change in test logic, just split up the test within a class and use the serve instance
edoakes
approved these changes
Jun 30, 2023
|
please update PR title to be more descriptive |
|
@edoakes ping for merge. Windows tests pass. |
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ime (ray-project#36988) rewrite test to use shared instance instead of ray shutdown. In my local, time is reduced from 40s to 23s. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
rewrite test to use shared instance instead of ray shutdown.
In my local, time is reduced from 40s to 23s.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.