Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[requirements] Install with compiled requirements as constraints [build_base] #36983

Merged
merged 85 commits into from
Jul 14, 2023
Merged

[requirements] Install with compiled requirements as constraints [build_base] #36983

merged 85 commits into from
Jul 14, 2023
+587 −19

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Jun 30, 2023 •
edited
Loading

Why are these changes needed?

Following up from #36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Kai Fricke added 30 commits June 26, 2023 10:42
Move requirements files
0f18cce 
Signed-off-by: Kai Fricke <kai@anyscale.com>
replace
99c8e4b 
Signed-off-by: Kai Fricke <kai@anyscale.com>
split some files
2ed7c75 
Signed-off-by: Kai Fricke <kai@anyscale.com>
ml dockerfile
e18ec73 
Signed-off-by: Kai Fricke <kai@anyscale.com>
export [build_base]
dab5995 
Signed-off-by: Kai Fricke <kai@anyscale.com>
fix core-requirements [build_base]
d88f126 
Signed-off-by: Kai Fricke <kai@anyscale.com>
move core requirements install [build_base]
1397c2e 
Signed-off-by: Kai Fricke <kai@anyscale.com>
Fix pipeline installs [build_base]
d2c5a90 
Signed-off-by: Kai Fricke <kai@anyscale.com>
HEBO 0.3.4 [build_base]
ec48911 
Signed-off-by: Kai Fricke <kai@anyscale.com>
mosaicml [build_base]
8452351 
Signed-off-by: Kai Fricke <kai@anyscale.com>
pymoo [build_base]
e858eb6 
Signed-off-by: Kai Fricke <kai@anyscale.com>
Merge remote-tracking branch 'upstream/master' into requirements/tiers
f3f3d28
trivial [build_base]
6ef9515 
Signed-off-by: Kai Fricke <kai@anyscale.com>
core [build_base]
fff3935 
Signed-off-by: Kai Fricke <kai@anyscale.com>
doctest mosaic [build_base]
bc2427a 
Signed-off-by: Kai Fricke <kai@anyscale.com>
Merge branch 'master' into requirements/tiers
bb2a99c
Move back to ml/
1ebd59b 
Signed-off-by: Kai Fricke <kai@anyscale.com>
Compile requirements [build_base]
25879d8 
Signed-off-by: Kai Fricke <kai@anyscale.com>
move [build_base]
d0d70c4 
Signed-off-by: Kai Fricke <kai@anyscale.com>
myst
79e0457 
Signed-off-by: Kai Fricke <kai@anyscale.com>
myst [build_base]
4cd074b 
Signed-off-by: Kai Fricke <kai@anyscale.com>
myst-parser [build_base]
cd76a02 
Signed-off-by: Kai Fricke <kai@anyscale.com>
myst-parser [build_base]
936c07f 
Signed-off-by: Kai Fricke <kai@anyscale.com>
move to test dockerfile [build_base]
e05e1cb 
Signed-off-by: Kai Fricke <kai@anyscale.com>
pip [build_base]
bc1eb80 
Signed-off-by: Kai Fricke <kai@anyscale.com>
bash [build_base]
698b1b0 
Signed-off-by: Kai Fricke <kai@anyscale.com>
no uninstall [build_base]
9ac12e1 
Signed-off-by: Kai Fricke <kai@anyscale.com>
install/uninstall torch [build_base]
ab5c6e4 
Signed-off-by: Kai Fricke <kai@anyscale.com>
not quiet [build_base]
1831ca2 
Signed-off-by: Kai Fricke <kai@anyscale.com>
torch again [build_base]
24ededf 
Signed-off-by: Kai Fricke <kai@anyscale.com>
@krfricke krfricke merged commit 0da6a98 into ray-project:master Jul 14, 2023
@krfricke krfricke deleted the requirements/tiers-constraint branch July 14, 2023 20:50
pcmoritz added a commit that referenced this pull request Jul 15, 2023
@pcmoritz
Revert "[requirements] Install with compiled requirements as constrai…
01ba493 
…nts [build_base] (#36983)"

This reverts commit 0da6a98.
@pcmoritz pcmoritz mentioned this pull request Jul 15, 2023
Merged
krfricke added a commit that referenced this pull request Jul 16, 2023
@krfricke
Revert "Revert "[requirements] Install with compiled requirements as …
24f3710 
…constraints [build_base] (#36983)" (#37458)"

This reverts commit 38ca6eb.
krfricke pushed a commit that referenced this pull request Jul 16, 2023
@pcmoritz
Revert "[requirements] Install with compiled requirements as constrai…
38ca6eb 
…nts [build_base] (#36983)" (#37458)

This reverts commit 0da6a98.
krfricke added a commit that referenced this pull request Jul 17, 2023
@krfricke
Revert "Revert "[requirements] Install with compiled requirements as …
0591417 
…constraints [build_base] (#36983)" (#37458)" (#37460)

This reverts commit 38ca6eb.
krfricke added a commit to krfricke/ray that referenced this pull request Jul 18, 2023
@krfricke
[requirements] Install with compiled requirements as constraints [bui…
529d913 
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
@krfricke @Bhav00
[requirements] Install with compiled requirements as constraints [bui…
a9d8de0 
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
@pcmoritz @Bhav00
Revert "[requirements] Install with compiled requirements as constrai…
9c9d999 
…nts [build_base] (ray-project#36983)" (ray-project#37458)

This reverts commit 0da6a98.
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
@krfricke @Bhav00
Revert "Revert "[requirements] Install with compiled requirements as …
5fc3816 
…constraints [build_base] (ray-project#36983)" (ray-project#37458)" (ray-project#37460)

This reverts commit 38ca6eb.
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
@krfricke @NripeshN
[requirements] Install with compiled requirements as constraints [bui…
9dfd5a2 
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: NripeshN <nn2012@hw.ac.uk>
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
@pcmoritz @NripeshN
Revert "[requirements] Install with compiled requirements as constrai…
a4087a3 
…nts [build_base] (ray-project#36983)" (ray-project#37458)

This reverts commit 0da6a98.

Signed-off-by: NripeshN <nn2012@hw.ac.uk>
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
@krfricke @NripeshN
Revert "Revert "[requirements] Install with compiled requirements as …
9ca3c65 
…constraints [build_base] (ray-project#36983)" (ray-project#37458)" (ray-project#37460)

This reverts commit 38ca6eb.

Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@krfricke @arvind-chandra
[requirements] Install with compiled requirements as constraints [bui…
b352e2e 
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@pcmoritz @arvind-chandra
Revert "[requirements] Install with compiled requirements as constrai…
d64c47b 
…nts [build_base] (ray-project#36983)" (ray-project#37458)

This reverts commit 0da6a98.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@krfricke @arvind-chandra
Revert "Revert "[requirements] Install with compiled requirements as …
ec891ed 
…constraints [build_base] (ray-project#36983)" (ray-project#37458)" (ray-project#37460)

This reverts commit 38ca6eb.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@krfricke
[requirements] Install with compiled requirements as constraints [bui…
eb599d2 
…ld_base] (ray-project#36983)

Following up from ray-project#36808, this PR now uses the compiled constraints file in the installation of the dependencies in CI and in the ray-ml docker images. In result, both environments will share the same versions of (sub)dependencies.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@pcmoritz
Revert "[requirements] Install with compiled requirements as constrai…
959b6f2 
…nts [build_base] (ray-project#36983)" (ray-project#37458)

This reverts commit 0da6a98.

Signed-off-by: Victor <vctr.y.m@example.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@krfricke
Revert "Revert "[requirements] Install with compiled requirements as …
94efd9f 
…constraints [build_base] (ray-project#36983)" (ray-project#37458)" (ray-project#37460)

This reverts commit 38ca6eb.

Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmoritz pcmoritz pcmoritz left review comments

@aslonnie aslonnie aslonnie left review comments

@matthewdeng matthewdeng matthewdeng approved these changes

@amogkam amogkam amogkam approved these changes

@can-anyscale can-anyscale can-anyscale approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw is a code owner

Assignees

@pcmoritz pcmoritz

@matthewdeng matthewdeng

@richardliaw richardliaw

@aslonnie aslonnie

@can-anyscale can-anyscale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@krfricke @can-anyscale @aslonnie @pcmoritz @matthewdeng @amogkam @richardliaw