Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] [Docs] Add note about DAGDriver redirect #36971

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

shrekris-anyscale
Copy link
Contributor

Why are these changes needed?

The DAGDrvier does an HTTP redirect when processing requests. If users query a DAGDriver endpoint with curl, the request won't return anything unless they include the -L flag, which makes curl follow redirects.

This change adds a note about this.

Related issue number

Closes #36773.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • This change relies on existing tests.

Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@edoakes edoakes merged commit fb087d6 into ray-project:master Jun 30, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
The `DAGDrvier` does an HTTP redirect when processing requests. If users query a `DAGDriver` endpoint with `curl`, the request won't return anything unless they include the `-L` flag, which makes `curl` follow redirects.

This change adds a note about this.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ray Serve DAGDriver
2 participants