Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][autoscaler] Remove usage of grpcio from autoscaler SDK #36967

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Jun 29, 2023

Why are these changes needed?

Since we should not be using grpcio python (aligning with this #35472)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx requested review from a team, wuisawesome, DmitriGekhtman and ericl as code owners June 29, 2023 22:05
@rickyyx
Copy link
Contributor Author

rickyyx commented Jun 29, 2023

The test is at

def test_request_cluster_resources_basic(shutdown_only):
ray.init(num_cpus=1)
stub = _autoscaler_state_service_stub()
# Request one
request_cluster_resources([{"CPU": 1}])
def verify():
reply = get_cluster_resource_state(stub)
assert_cluster_resource_constraints(reply, [{"CPU": 1}])
return True
wait_for_condition(verify)
# Request another overrides the previous request
request_cluster_resources([{"CPU": 2, "GPU": 1}, {"CPU": 1}])
def verify():
reply = get_cluster_resource_state(stub)
assert_cluster_resource_constraints(reply, [{"CPU": 2, "GPU": 1}, {"CPU": 1}])
return True
wait_for_condition(verify)

Signed-off-by: rickyyx <rickyx@anyscale.com>
@scv119 scv119 merged commit 22b50e4 into ray-project:master Jun 30, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…oject#36967)

Why are these changes needed?
Since we should not be using grpcio python (aligning with this ray-project#35472)

---------

Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants