Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] Standardize Dataset APIs #36937

Merged
merged 11 commits into from
Jun 30, 2023
Merged

[data] Standardize Dataset APIs #36937

merged 11 commits into from
Jun 30, 2023

Conversation

raulchen
Copy link
Contributor

Why are these changes needed?

This PR standardizes the following sections of Dataset APIs:
I/O and Conversion
Inspecting Metadata
Execution
Serialization

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

raulchen added 5 commits June 28, 2023 18:19
@raulchen
write_xxx
255ac08 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen
to_xxx
64b95ec 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen
metadata apis
6affc8d 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen
materialize
41b6fd5 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen
serialize
e669d3d 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@bveeramani bveeramani self-assigned this Jun 29, 2023
@bveeramani
Update dataset.py
ddd3b3c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update dataset.py
0e717d5 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
raulchen added 4 commits June 30, 2023 10:28
@raulchen
Merge branch 'master' into standardize-write-api
d92cb60
@raulchen
lint
e123b05 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen
fix
3a42250 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen
fix
e2954f3 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen changed the title [data] Standardize APIs [data] Standardize Dataset APIs Jun 30, 2023
@raulchen raulchen merged commit d962918 into ray-project:master Jun 30, 2023
@raulchen raulchen deleted the standardize-write-api branch June 30, 2023 23:46
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@raulchen @bveeramani @arvind-chandra
[data] Standardize Dataset APIs (ray-project#36937)
a124014 
---------

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bveeramani bveeramani bveeramani approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@c21 c21 Awaiting requested review from c21

@amogkam amogkam Awaiting requested review from amogkam

@scottjlee scottjlee Awaiting requested review from scottjlee

Assignees

@bveeramani bveeramani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulchen @bveeramani