[core][autoscaler] Add idle time information to autoscaler endpoint. #36918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
reviewed
Jun 29, 2023
| @@ -175,41 +175,52 @@ void GcsAutoscalerStateManager::GetPendingResourceRequests( | |||
|
|
|||
| void GcsAutoscalerStateManager::GetNodeStates( | |||
| rpc::autoscaler::ClusterResourceState *state) { | |||
| auto populate_node_state = [&](const rpc::GcsNodeInfo &gcs_node_info, | |||
| rpc::autoscaler::NodeStatus status) { | |||
| auto populate_node_state = [&](const rpc::GcsNodeInfo &gcs_node_info) { | |||
There was a problem hiding this comment.
is this change covered by test? (non idle part specifically)
There was a problem hiding this comment.
scv119
approved these changes
Jun 29, 2023
…uto-state-update-time
…uto-state-update-time
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ay-project#36918) This PR populates the `idle_duration_ms` for each node, that's part of the cluster resources state. This allows autosclaer to decide if a node is idle. This completes ray-project#36670, which surfaced idle info from raylet. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR populates the
idle_duration_msfor each node, that's part of the cluster resources state.This allows autosclaer to decide if a node is idle.
This completes #36670, which surfaced idle info from raylet.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.