Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[air/deprecations] Deprecate some redundant syncing related parameters #36900

Merged
merged 8 commits into from
Jun 29, 2023
Merged

[air/deprecations] Deprecate some redundant syncing related parameters #36900

merged 8 commits into from
Jun 29, 2023

Conversation

justinvyu
Copy link
Contributor

Why are these changes needed?

This PR takes care of redundant syncing-related parameters that have been scheduled to be removed/hard-deprecated. This includes:

  • Trainable(custom_syncer, sync_timeout) in favor of Trainable(sync_config)
  • ExperimentAnalysis(sync_config) in favor of ExperimentAnalysis(remote_storage_path)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

justinvyu added 4 commits June 28, 2023 01:09
@justinvyu
Remove trainable sync_x params
8efe1b5 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Hard deprecate sync config param of ExpAnalysis
6d28bb2 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Remove sync_config usage in tune.run
0b1a17b 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Fix lint
c76f049 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu requested a review from krfricke June 28, 2023 08:14
justinvyu added 4 commits June 29, 2023 00:42
@justinvyu
Remove usage of the deprecated params
c3d7dba 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Remove more usage of deprecated params
06cbfbe 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into air/…
2f121c6 
…deprecations/trainable_params
@justinvyu
Fix lint
9e9dad0 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu requested a review from matthewdeng June 29, 2023 17:08
@justinvyu justinvyu marked this pull request as ready for review June 29, 2023 17:08
@justinvyu justinvyu added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 29, 2023
matthewdeng
matthewdeng approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for cleaning this up!

@matthewdeng matthewdeng merged commit 520543d into ray-project:master Jun 29, 2023
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@justinvyu @arvind-chandra
[air/deprecations] Deprecate some redundant syncing related parameters (
6a0d977 
ray-project#36900)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@krfricke krfricke

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinvyu @matthewdeng @krfricke