Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client] Implement runtime_context().gcs_address #36895

Merged
merged 10 commits into from
Jun 29, 2023

Conversation

ckw017
Copy link
Member

@ckw017 ckw017 commented Jun 28, 2023

Why are these changes needed?

Fixes gcs_address for RuntimeContexts on Ray Client.

Related issue number

Closes #36833

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

ckw017 added 10 commits May 19, 2023 16:23
Signed-off-by: Chris Wong <cwong@anyscale.com>
Signed-off-by: Chris Wong <cwong@anyscale.com>
Signed-off-by: Chris Wong <cwong@anyscale.com>
Signed-off-by: Chris Wong <cwong@anyscale.com>
Signed-off-by: Chris Wong <cwong@anyscale.com>
Signed-off-by: Chris Wong <cwong@anyscale.com>
Copy link
Contributor

@ijrsvt ijrsvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckw017
Copy link
Member Author

ckw017 commented Jun 28, 2023

@rkooo567 can I get help merging this, I'm not a committer

@rkooo567
Copy link
Contributor

Serve failures seem unrelated

@rkooo567 rkooo567 merged commit 24dea87 into ray-project:master Jun 29, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Fixes gcs_address for RuntimeContexts on Ray Client.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Unable to getgcs_address when connected to an external cluster
3 participants