Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Add region name for boto3 erc client #36892

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[ci] Add region name for boto3 erc client #36892

merged 1 commit into from
Jun 28, 2023

Conversation

can-anyscale
Copy link
Collaborator

Add region name when getting boto3 ecr client. For some reason, this is required when running this script inside py38 docker image.

  • Testing Strategy
    • Unit tests
    • Release tests

@can-anyscale
Add region name for boto3 erc client
7414830 
Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale requested a review from a team as a code owner June 28, 2023 00:15
aslonnie
aslonnie approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably because it is missing AWS_REGION or some env var.

@can-anyscale can-anyscale added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 28, 2023
@richardliaw richardliaw merged commit c464026 into master Jun 28, 2023
@richardliaw richardliaw deleted the can-boto-region branch June 28, 2023 17:00
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@can-anyscale @arvind-chandra
[ci] Add region name for boto3 erc client (ray-project#36892)
f918b64 
Signed-off-by: can <can@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslonnie aslonnie aslonnie approved these changes

Assignees
No one assigned
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@can-anyscale @aslonnie @richardliaw