Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Fix progress bar initial value #36890

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

raulchen
Copy link
Contributor

@raulchen raulchen commented Jun 27, 2023

Why are these changes needed?

This is a bug introduced by #36679.
I thought position was the bar position (initial progress). But it is actually the line position to print the bar. Rename the variable to "progress", and default initial value to 0.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen changed the title [Data] Fix progress bar inital value [Data] Fix progress bar initial value Jun 27, 2023
@pcmoritz
Copy link
Contributor

Thanks for fixing this, I'll quickly try it out before merging :)

@raulchen
Copy link
Contributor Author

@pcmoritz I've tried your snippet locally, looked good.

@pcmoritz
Copy link
Contributor

Thanks, it definitely looks better, but I'm still seeing cases where the progress bars stay uncompleted:

Screen Shot 2023-06-27 at 5 08 46 PM

The full repro is with VSCode and this notebook here: https://github.com/anyscale/Made-With-ML/blob/main/notebooks/madewithml.ipynb

@raulchen
Copy link
Contributor Author

Got it. There might be another issue. Let me merge this PR first. Will create another PR for the remaining issue(s).

@raulchen raulchen merged commit 8ae0fa5 into ray-project:master Jun 28, 2023
@raulchen raulchen deleted the fix-progress-bar branch June 28, 2023 23:29
@raulchen
Copy link
Contributor Author

@pcmoritz I think that is expected. Because when you call next(ds.iter_batches)), the data is not fully consumed yet. When it's fully consumed, the progress bar will finish.

arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
This is a bug introduced by ray-project#36679.
I thought `position` was the bar position (initial progress). But it is actually the line position to print the bar. Rename the variable to "progress", and default initial value to 0.

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants