-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] [Minimal install] Check python version in minimal install #36887
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7aa1d54
Asserting Python version in minimal tests
cadedaniel 1f5867e
Validate Bazel uses correct Python version
cadedaniel 4211441
Lint
cadedaniel 91b4c5d
fix
cadedaniel 6c4a245
Fixed for py37
cadedaniel 8c0ed9a
Adding set -x to 3.11
cadedaniel 9bbaaa3
Making check optional in check_minimal_install for Train test
cadedaniel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# coding: utf-8 | ||
""" | ||
Tests that are specific to minimal installations. | ||
""" | ||
|
||
import pytest | ||
import os | ||
import sys | ||
|
||
|
||
@pytest.mark.skipif( | ||
os.environ.get("RAY_MINIMAL", "0") != "1", | ||
reason="Skip unless running in a minimal install.", | ||
) | ||
def test_correct_python_version(): | ||
""" | ||
Validate that Bazel uses the correct Python version in our minimal tests. | ||
""" | ||
expected_python_version = os.environ.get("EXPECTED_PYTHON_VERSION", "").strip() | ||
assert ( | ||
expected_python_version | ||
), f"EXPECTED_PYTHON_VERSION is {expected_python_version}" | ||
|
||
actual_major, actual_minor = sys.version_info[:2] | ||
actual_version = f"{actual_major}.{actual_minor}" | ||
assert actual_version == expected_python_version, ( | ||
f"expected_python_version={expected_python_version}" | ||
f"actual_version={actual_version}" | ||
) | ||
|
||
|
||
if __name__ == "__main__": | ||
if os.environ.get("PARALLEL_CI"): | ||
sys.exit(pytest.main(["-n", "auto", "--boxed", "-vs", __file__])) | ||
else: | ||
sys.exit(pytest.main(["-sv", __file__])) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of an "easier" approach where we just asserted the python version in shell here like check the
python --version
output.What's the motif for running another pytest and assert in there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how bazel works, so wanted to verify that bazel picks up right version. If someone confident in bazel behavior says we can trust it, I can delete the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion here - I' m ok with the current approach.