-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serve] Add Java support for power of two choices routing (RAY_SERVE_ENABLE_NEW_ROUTING=1
)
#36865
Conversation
fa93d42
to
cfad45e
Compare
4afa6e7
to
1ee49ca
Compare
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
RAY_SERVE_ENABLE_NEW_ROUTING=1
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Does this change need any additional tests? I think existing tests should be sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shrekris-anyscale the existing java tests are sufficient! The core routing logic is shared. |
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
…_ENABLE_NEW_ROUTING=1`) (ray-project#36865) This is required to turn the new routing on by default. Also adds a build to test this condition. Only required adding the same method for fetching the queue length to the Java replica. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Why are these changes needed?
This is required to turn the new routing on by default. Also adds a build to test this condition.
Only required adding the same method for fetching the queue length to the Java replica.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.