Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Add Java support for power of two choices routing (RAY_SERVE_ENABLE_NEW_ROUTING=1) #36865

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Jun 27, 2023

Why are these changes needed?

This is required to turn the new routing on by default. Also adds a build to test this condition.

Only required adding the same method for fetching the queue length to the Java replica.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes edoakes force-pushed the choose-two-java branch 2 times, most recently from 4afa6e7 to 1ee49ca Compare June 28, 2023 16:08
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested a review from a team June 28, 2023 16:13
@edoakes edoakes changed the title [WIP][serve] java power of two routing [serve] Add Java support for power of two choices routing (RAY_SERVE_ENABLE_NEW_ROUTING=1) Jun 28, 2023
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Does this change need any additional tests? I think existing tests should be sufficient.

Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edoakes
Copy link
Contributor Author

edoakes commented Jun 28, 2023

@shrekris-anyscale the existing java tests are sufficient! The core routing logic is shared.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
edoakes added 2 commits June 28, 2023 14:11
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes merged commit ca8c76d into ray-project:master Jun 28, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…_ENABLE_NEW_ROUTING=1`) (ray-project#36865)

This is required to turn the new routing on by default. Also adds a build to test this condition.

Only required adding the same method for fetching the queue length to the Java replica.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants