Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] RLlib deprecation Notices Part 2 (models/tf, models/torch, base_mode, catalog, modelv2, models/temp_spec_classes, policy/) #36840

Merged
merged 8 commits into from
Jun 29, 2023
Merged

[RLlib] RLlib deprecation Notices Part 2 (models/tf, models/torch, base_mode, catalog, modelv2, models/temp_spec_classes, policy/) #36840

merged 8 commits into from
Jun 29, 2023

Conversation

avnishn
Copy link
Member

@avnishn avnishn commented Jun 26, 2023

Signed-off-by: Avnish avnishnarayan@gmail.com

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@avnishn
[RLlib] RLlib deprecation Notices Part 2 (models/tf, models/torch, ba…
86c23b4 
…se_mode, catalog, modelv2, models/temp_spec_classes, policy/)

Signed-off-by: Avnish <avnishnarayan@gmail.com>
avnishn added 2 commits June 26, 2023 17:13
@avnishn
Add more deprecations
9fe55d5 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
More Deprecations
4f21f84 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
avnishn
avnishn commented Jun 27, 2023
View reviewed changes
rllib/models/tf/noop.py Outdated Show resolved Hide resolved
avnishn
avnishn commented Jun 27, 2023
View reviewed changes
rllib/models/torch/mingpt.py Outdated Show resolved Hide resolved
avnishn
avnishn commented Jun 27, 2023
View reviewed changes
rllib/models/torch/model.py Outdated Show resolved Hide resolved
avnishn
avnishn commented Jun 27, 2023
View reviewed changes
rllib/models/torch/noop.py Outdated Show resolved Hide resolved
avnishn
avnishn commented Jun 27, 2023
View reviewed changes
Copy link
Member Author

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass review

@avnishn
Address comments
6c844e4 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Fix broken import
2f06c0b 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@Rohan138
Copy link
Contributor

lgtm, not a codeowner, @kouroshHakha can you stamp?

@avnishn
Change to deprecation warning for recurrent network lstm wrapper
41a935b 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@kouroshHakha
Copy link
Contributor

@avnishn tests are failing.

avnishn added 2 commits June 28, 2023 16:00
@avnishn
Fix rnn errors
00516ca 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Fix broken test
9ecf52e 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@kouroshHakha kouroshHakha added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 29, 2023
@kouroshHakha kouroshHakha merged commit 49342d5 into ray-project:master Jun 29, 2023
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@avnishn @arvind-chandra
[RLlib] RLlib deprecation Notices Part 2 (models/tf, models/torch, ba…
1246ef9 
…se_mode, catalog, modelv2, models/temp_spec_classes, policy/) (ray-project#36840)

Signed-off-by: Avnish <avnishnarayan@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kouroshHakha kouroshHakha kouroshHakha approved these changes

@sven1977 sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

@gjoliver gjoliver Awaiting requested review from gjoliver

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@Rohan138 Rohan138

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avnishn @Rohan138 @kouroshHakha