Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] update active nodes before updating http states #36820

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Jun 26, 2023

Why are these changes needed?

Update active nodes right before update the http states so they are more consistent.

Related issue number

RE: #36652 (comment)

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer GeneDer requested a review from edoakes June 26, 2023 18:53
@edoakes edoakes merged commit 2830199 into ray-project:master Jun 26, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…36820)

Update active nodes right before update the http states so they are more consistent.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants