[core] Clear CPU affinity for worker processes #36816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
rkooo567
reviewed
Jun 26, 2023
|
|
||
| // Clear any CPU affinity that might have been inherited from the raylet. | ||
| // See https://github.com/ray-project/ray/issues/35984. | ||
| cpu_set_t mask; |
There was a problem hiding this comment.
Is it possible to add a test for this one?
There was a problem hiding this comment.
I don't know of a good way to do it (in the PR description: This PR is not tested because the best way to do so would require sudo permissions.). What do you think?
There was a problem hiding this comment.
Oops. Sorry I missed that comment. I think it is okay to merge if you manually have checked it then.
There was a problem hiding this comment.
Lmk if you tested manually!
rkooo567
approved these changes
Jun 29, 2023
jjyao
pushed a commit
that referenced
this pull request
Jun 29, 2023
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Clear CPU affinity for worker processes when forking from raylet. See ray-project#35984 for more details. This PR is not tested because the best way to do so would require sudo permissions. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…6816)" (ray-project#36958) This reverts commit 92cc3c3. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Clear CPU affinity for worker processes when forking from raylet. See #35984 for more details.
This PR is not tested because the best way to do so would require sudo permissions.
Related issue number
Closes #35984.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.