[Data] Refactor .distinct() to .unique() #36802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulchen
approved these changes
Jun 25, 2023
| @@ -219,22 +219,16 @@ def test_repartition_shuffle_arrow(ray_start_regular_shared): | |||
|
|
|||
| def test_distinct(ray_start_regular_shared): | |||
There was a problem hiding this comment.
change this test name as well?
There was a problem hiding this comment.
Updated, great catch!
ericl
reviewed
Jun 26, 2023
ericl
approved these changes
Jun 26, 2023
Co-authored-by: Eric Liang <ekhliang@gmail.com> Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
It turns out for the use cases in ray-project#32984, the previous `.distinct()` API was not quite the right API -- the function is actually being used to get distinct labels or values in a dataset and therefore returning a list is the most convenient. This is very in line with Ray Data being a last mile data processing framework. Also HuggingFace datasets already has a good API for this, so we are implementing a similar API here, see also https://huggingface.co/docs/datasets/v2.13.1/en/package_reference/main_classes#datasets.Dataset.unique Co-authored-by: Eric Liang <ekhliang@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It turns out for the use cases in #32984, the previous
.distinct()API was not quite the right API -- the function is actually being used to get distinct labels or values in a dataset and therefore returning a list is the most convenient. This is very in line with Ray Data being a last mile data processing framework.Also HuggingFace datasets already has a good API for this, so we are implementing a similar API here, see also https://huggingface.co/docs/datasets/v2.13.1/en/package_reference/main_classes#datasets.Dataset.unique
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.