Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] add shallow_since in rules_perl #36793

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Conversation

aslonnie
Copy link
Collaborator

so that it does not need to clone the entire repo.

this is recommended by latest bazel build command.

so that it does not need to clone the entire repo.

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -261,6 +261,7 @@ def ray_deps_setup():
name = "rules_perl",
remote = "https://github.com/bazelbuild/rules_perl.git",
commit = "022b8daf2bb4836ac7a50e4a1d8ea056a3e1e403",
shallow_since = "1663780239 -0700",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe put a link to bazel documentation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fairly standard thing for using git_repository: https://bazel.build/rules/lib/repo/git

the hint to add a shallow_since is provided by bazel build process in the build logs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments.

@aslonnie aslonnie added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 26, 2023
@richardliaw richardliaw merged commit 259b521 into master Jun 27, 2023
@richardliaw richardliaw deleted the lonnie-0623-rulesperl branch June 27, 2023 06:15
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants