-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] add shallow_since in rules_perl #36793
Conversation
so that it does not need to clone the entire repo. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -261,6 +261,7 @@ def ray_deps_setup(): | |||
name = "rules_perl", | |||
remote = "https://github.com/bazelbuild/rules_perl.git", | |||
commit = "022b8daf2bb4836ac7a50e4a1d8ea056a3e1e403", | |||
shallow_since = "1663780239 -0700", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe put a link to bazel documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's fairly standard thing for using git_repository
: https://bazel.build/rules/lib/repo/git
the hint to add a shallow_since
is provided by bazel build process in the build logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comments.
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
so that it does not need to clone the entire repo.
this is recommended by latest bazel build command.