-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Templates] Small fixes for 2.6 #36781
Conversation
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, changes look good to me. Unfortunately, this puts us in a catch-22 for the hyperlinks. If we link with latest, the master docs will be incorrect. If we link with master, then the release docs will be incorrect.
For 2.6, should we keep them as separate examples until we figure out a long term approach for consolidation?
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on Amog
Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Why are these changes needed?
This PR updates the batch inference example content based on @angelinalg's feedback. This also remove the duplicate copy that was used for the workspace template. Now, only one copy of this example lives in
doc/source/templates/01_batch_inferece/start.ipynb
, and the one indoc/source/data/examples
is just a symlink. The example uses absolute urls so that the links all work on Anyscale. The reason for this is that maintaining 2 versions is way too much overhead even on minor edits such as these.For reviewers
Link to the updated content: https://anyscale-ray--36781.com.readthedocs.build/en/36781/data/examples/pytorch_resnet_batch_prediction.html
Main content changes:
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.