Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] unmark documentation test as soft fail #36750

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

matthewdeng
Copy link
Contributor

Why are these changes needed?

Reverts #36480 since this test is now passing.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng matthewdeng marked this pull request as ready for review June 23, 2023 04:31
@matthewdeng
Copy link
Contributor Author

matthewdeng commented Jun 23, 2023

Documentation test in master is passing now.

Documentation test is failing on the PR job, but this seems to be due to some caching behavior me forgetting to merge master.

@matthewdeng matthewdeng added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 23, 2023
@aslonnie
Copy link
Collaborator

this seems to be due to some caching behavior.

your pr does not include the final fix PR; it is 3 commits behind master:

matthewdeng/ray@docs-softfail...ray-project:ray:master
image

you should merge master head and rerun the tests.

Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge master head and include the fix required.

@matthewdeng
Copy link
Contributor Author

Lol woops.

@matthewdeng matthewdeng merged commit e5ec46f into ray-project:master Jun 23, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants