Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Rename test_serve_agent_fault_tolerance.py #36745

Merged

Conversation

shrekris-anyscale
Copy link
Contributor

Why are these changes needed?

test_serve_agent_fault_tolerane.py is misspelled (tolerane instead of tolerance). This change fixes the typo and renames the test test_serve_agent_fault_tolerance.py.

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • This change only renames a test.

Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you don't need to rename something in a BUILD file

@shrekris-anyscale
Copy link
Contributor Author

Make sure you don't need to rename something in a BUILD file

I took a look– I don't think we need to update any BUILD files.

@shrekris-anyscale
Copy link
Contributor Author

The documentation errors are unrelated:

  • Lint was failing on master:
Screen Shot 2023-06-23 at 11 25 47 AM Screen Shot 2023-06-23 at 11 26 41 AM
+ docker run --rm -v /ray:/ray-mounted ubuntu:focal ls /
--
  | Unable to find image 'ubuntu:focal' locally
  | docker: Error response from daemon: Get "https://registry-1.docker.io/v2/": net/http: request canceled (Client.Timeout exceeded while awaiting headers).
  | See 'docker run --help'.
  | 🚨 Error: The command exited with status 125

@shrekris-anyscale
Copy link
Contributor Author

@architkulkarni @edoakes this change is ready to merge.

@architkulkarni architkulkarni merged commit d93cfee into ray-project:master Jun 23, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
test_serve_agent_fault_tolerane.py is misspelled (tolerane instead of tolerance). This change fixes the typo and renames the test test_serve_agent_fault_tolerance.py.

Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants