Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Fix documentation failure due to typing_extensions #36732

Merged
merged 3 commits into from
Jun 23, 2023
Merged

[doc] Fix documentation failure due to typing_extensions #36732

merged 3 commits into from
Jun 23, 2023

Conversation

fishbone
Copy link
Contributor

@fishbone fishbone commented Jun 22, 2023 •
edited
Loading

Signed-off-by: Yi Cheng 74173148+iycheng@users.noreply.github.com

Why are these changes needed?

pydantic is not compatible with typing extensions. After pip install "mosaicml==0.12.1" "urllib3<1.27", typing-extensions somehow changes to 4.6 which is not working with pandantic.

Another way to fix this is to upgrade pandantic version, but it breaks tests.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone
fix
9ff1254 
Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
@fishbone
fix
e1cea8a 
Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
@fishbone fishbone changed the title fix [doc] Fix documentation failure due to python upgrading Jun 23, 2023
@fishbone fishbone marked this pull request as ready for review June 23, 2023 01:25
@fishbone fishbone marked this pull request as draft June 23, 2023 01:30
@fishbone
fix
59191e5 
Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
@fishbone fishbone changed the title [doc] Fix documentation failure due to python upgrading [doc] Fix documentation failure due to typing_extensions Jun 23, 2023
@fishbone fishbone marked this pull request as ready for review June 23, 2023 02:03
matthewdeng
matthewdeng approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fishbone fishbone merged commit 0bbf900 into ray-project:master Jun 23, 2023
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@fishbone @arvind-chandra
[doc] Fix documentation failure due to typing_extensions (ray-project…
91dfc87 
…#36732)

## Why are these changes needed?
pydantic is not compatible with typing extensions. After `pip install "mosaicml==0.12.1" "urllib3<1.27"`, `typing-extensions` somehow changes to 4.6 which is not working with pandantic.

Another way to fix this is to upgrade pandantic version, but it breaks tests.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

Assignees

@matthewdeng matthewdeng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fishbone @matthewdeng