Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix rllib_learning_tests_ddpg_tf #36730

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jun 22, 2023

Why are these changes needed?

rllib_learning_tests_ddpg_tf test requires an older version of MuJoCo that is currently resolved by byod: https://buildkite.com/ray-project/release-tests-pr/builds/43243#0188e526-10fe-4700-b985-4f896d8cd787

Somehow pinning the version during byod runtime_env does not downgrade the package. Remove it from byod to unbreak the test first.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • Testing Strategy
    • Unit tests
    • Release tests

Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale changed the title Fix rllib_learning_tests_ddpg_tf [ci] Fix rllib_learning_tests_ddpg_tf Jun 22, 2023
@can-anyscale can-anyscale marked this pull request as ready for review June 22, 2023 22:37
@can-anyscale can-anyscale requested a review from a team June 22, 2023 22:38
@can-anyscale can-anyscale added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 22, 2023
@richardliaw richardliaw merged commit 79e1fa2 into master Jun 23, 2023
@richardliaw richardliaw deleted the can-fix-rllib-test branch June 23, 2023 17:47
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants