Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix bisect for byod #36711

Merged
merged 1 commit into from
Jun 23, 2023
Merged

[ci] fix bisect for byod #36711

merged 1 commit into from
Jun 23, 2023

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jun 22, 2023

Why are these changes needed?

Fix a couple of things for bisect to work properly with byod tests:

  • Validate that test has the 'smoke_test' entry
  • Passing COMMIT_TO_TEST env so that byod docker name can be obtained correctly
  • Do not skipping finding the right wheel even for byod test since the test might have not been byod yet in the range of bisect

Checks

@can-anyscale can-anyscale force-pushed the can-fix-bisect-byod branch from 0a76364 to affe14c Compare June 22, 2023 17:39
@can-anyscale can-anyscale changed the title Fix bisect for byod [ci] fix bisect for byod Jun 22, 2023
@can-anyscale can-anyscale marked this pull request as ready for review June 22, 2023 18:04
@can-anyscale can-anyscale requested a review from a team as a code owner June 22, 2023 18:04
@can-anyscale can-anyscale marked this pull request as draft June 22, 2023 18:33
@can-anyscale can-anyscale marked this pull request as ready for review June 22, 2023 18:34
Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale force-pushed the can-fix-bisect-byod branch from affe14c to 0f48ab1 Compare June 22, 2023 18:38
@richardliaw richardliaw merged commit 112ef5c into master Jun 23, 2023
@richardliaw richardliaw deleted the can-fix-bisect-byod branch June 23, 2023 17:48
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: can <can@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants