Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci][fix] fix a few data tests that require horovod #36708

Merged
merged 1 commit into from
Jun 23, 2023
Merged

[ci][fix] fix a few data tests that require horovod #36708

merged 1 commit into from
Jun 23, 2023

Conversation

can-anyscale
Copy link
Collaborator

Why are these changes needed?

Some of the current release data tests are failing because they require horovod. Add the dependency to fix them.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • Testing Strategy
    • Unit tests
    • Release tests

@can-anyscale can-anyscale requested review from c21, bveeramani and a team June 22, 2023 17:14
@can-anyscale can-anyscale marked this pull request as draft June 22, 2023 18:20
@can-anyscale can-anyscale force-pushed the can-fix-pipelined-test branch from 0cf4948 to 945185a Compare June 22, 2023 18:25
aslonnie
aslonnie reviewed Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ping me again when this is ready)

@can-anyscale can-anyscale force-pushed the can-fix-pipelined-test branch from 945185a to d939f95 Compare June 22, 2023 20:41
@can-anyscale
Fix a few data tests that require horovod
844ec18 
Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale force-pushed the can-fix-pipelined-test branch from d939f95 to 844ec18 Compare June 22, 2023 21:54
@can-anyscale can-anyscale marked this pull request as ready for review June 22, 2023 22:39
@can-anyscale can-anyscale requested a review from aslonnie June 22, 2023 22:39
@can-anyscale can-anyscale added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 22, 2023
@richardliaw richardliaw merged commit eceea0e into master Jun 23, 2023
@richardliaw richardliaw deleted the can-fix-pipelined-test branch June 23, 2023 17:47
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@can-anyscale @arvind-chandra
Fix a few data tests that require horovod (ray-project#36708)
2fe8803 
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslonnie aslonnie aslonnie approved these changes

@c21 c21 Awaiting requested review from c21

@bveeramani bveeramani Awaiting requested review from bveeramani

Assignees
No one assigned
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@can-anyscale @aslonnie @richardliaw