Adding new guides for developing and deploying an ML application in S… #36700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
reviewed
Jun 22, 2023
|
|
||
| These are all the properties available on a Ray Serve deployment. This is also available in the [API reference](../serve/api/doc/ray.serve.deployment_decorator.rst) | ||
|
|
||
| The following can be configured through either the serve config file or on the `@serve.deployment` decorator: |
There was a problem hiding this comment.
A few updates should be made to this content:
- Show a Python code sample and an equivalent config file.
- Show the usage of
.options(). - Explain the precedence (config > what's in the code).
I think we should also consolidate the content in the "app builder" page here to make it clear how to compose them. WDYT?
There was a problem hiding this comment.
Agreed I'll add this
There was a problem hiding this comment.
Added the 3 (actually moved them over from the serve config page because I think they're more relevant here). Also updated the serve config page. For the app builder, do you propose merging app builder content entirely into this page?
|
Some comments on the "configuring deployments" page. I'm OK with those changes being a follow-up, but I think they'll significantly reduce confusion. |
zcin
reviewed
Jun 22, 2023
angelinalg
approved these changes
Jun 23, 2023
angelinalg
approved these changes
Jun 23, 2023
|
Some content suggestions:
|
|
Addressed all the comments and updated the examples in the Serve config files page to use the multi-app schema |
c195441 to
76ddc36
Compare
edoakes
reviewed
Jun 27, 2023
f5bfb46 to
5b387cc
Compare
|
Updated with new feedback |
edoakes
approved these changes
Jun 27, 2023
angelinalg
approved these changes
Jun 28, 2023
ce6d98b to
0b7511d
Compare
…erve and configuring serve deployments. The change also includes refactoring information in some existing guides. Signed-off-by: Akshay Malik <akshay@anyscale.com>
0b7511d to
2f98c3a
Compare
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
ray-project#36700) The change also includes refactoring information in some existing guides. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erve and configuring serve deployments.
The change also includes refactoring information in some existing guides.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.