Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air/xgboost] XGBoost benchmark test without BYOD #36698

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Kai Fricke <kai@anyscale.com>
@krfricke krfricke added the do-not-merge Do not merge this PR! label Jun 22, 2023
@can-anyscale
Copy link
Collaborator

Let's do this!

@can-anyscale
Copy link
Collaborator

@krfricke let's do this first to unbreak the tests ;), I can take a look at byod separately, thankkks

@krfricke krfricke marked this pull request as ready for review June 26, 2023 17:59
@krfricke krfricke removed the do-not-merge Do not merge this PR! label Jun 26, 2023
@krfricke krfricke requested a review from can-anyscale June 26, 2023 18:00
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krfricke krfricke merged commit 82f96d6 into ray-project:master Jun 26, 2023
@krfricke krfricke deleted the air/xgboost-benchmark-no-byod branch June 26, 2023 18:20
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants