[ci] fix lint #36689
Merged
[ci] fix lint #36689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: can <can@anyscale.com>
aslonnie
approved these changes
Jun 22, 2023
| @@ -16,7 +16,7 @@ mkdir ~/.mujoco | |||
| mv mujoco210-linux-x86_64.tar.gz ~/.mujoco/. | |||
| cd ~/.mujoco | |||
| tar -xf ~/.mujoco/mujoco210-linux-x86_64.tar.gz | |||
| echo 'export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/home/ray/.mujoco/mujoco210/bin' >> /home/ray/.bashrc | |||
| echo "export LD_LIBRARY_PATH=\$LD_LIBRARY_PATH:/home/ray/.mujoco/mujoco210/bin" >> /home/ray/.bashrc | |||
There was a problem hiding this comment.
hmm.... you actually meant to not escape huh.. not sure if there is some way to tell the linter to ignore this.
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Signed-off-by: can <can@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Lint is complaining that I'm using single quote. Use double quote and escape character instead.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.tests.ray.io/