Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Enforce strict mode batch format for DataIterator.iter_batches() #36686

Merged
merged 7 commits into from
Jun 23, 2023

Conversation

scottjlee
Copy link
Contributor

@scottjlee scottjlee commented Jun 22, 2023

Why are these changes needed?

As strict mode is enabled, ensure that we apply _apply_strict_mode_batch_format to the input batch format for DataIterator.iter_batches(), so that the default batch format is numpy.

Related issue number

Closes #36709

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Scott Lee added 2 commits June 21, 2023 17:30
Signed-off-by: Scott Lee <sjl@anyscale.com>
Scott Lee added 5 commits June 21, 2023 18:37
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
fix
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
@scottjlee scottjlee marked this pull request as ready for review June 22, 2023 21:41
@scottjlee scottjlee added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 22, 2023
@ericl ericl merged commit 2c34cc7 into ray-project:master Jun 23, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…s()` (ray-project#36686)

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data] DataIterator.iter_batches() does not use default numpy batch format
2 participants