-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][byod] support python 3.9 #36672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12b489e
to
896d7a1
Compare
327609d
to
8d0c641
Compare
e38a7e6
to
ec2a928
Compare
aslonnie
approved these changes
Jun 22, 2023
aslonnie
reviewed
Jun 22, 2023
|
||
|
||
def test_get_anyscale_byod_image(): | ||
os.environ["BUILDKITE_BRANCH"] = "master" | ||
os.environ["BUILDKITE_COMMIT"] = "1234567890" | ||
assert ( | ||
_stub_test({}).get_anyscale_byod_image() | ||
_stub_test({"python": "3.7", "cluster": {"byod": {}}}).get_anyscale_byod_image() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this "3.7"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be any version, mostly so that I don't have to change the output
Signed-off-by: can <can@anyscale.com>
Signed-off-by: can <can@anyscale.com>
ec2a928
to
bc24dda
Compare
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Support BYOD release test build for py39. We do this by cloning several versions of requirements, one for each python version
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.