Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][byod] support python 3.9 #36672

Merged
merged 2 commits into from
Jun 23, 2023
Merged

[ci][byod] support python 3.9 #36672

merged 2 commits into from
Jun 23, 2023

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jun 21, 2023

Why are these changes needed?

Support BYOD release test build for py39. We do this by cloning several versions of requirements, one for each python version

Checks

@can-anyscale can-anyscale changed the base branch from master to can-byod-rllib-tests June 21, 2023 21:39
@can-anyscale can-anyscale force-pushed the can-byod-py39 branch 2 times, most recently from 12b489e to 896d7a1 Compare June 21, 2023 23:07
@can-anyscale can-anyscale force-pushed the can-byod-rllib-tests branch 4 times, most recently from 327609d to 8d0c641 Compare June 22, 2023 00:10
Base automatically changed from can-byod-rllib-tests to master June 22, 2023 00:12
@can-anyscale can-anyscale force-pushed the can-byod-py39 branch 7 times, most recently from e38a7e6 to ec2a928 Compare June 22, 2023 04:01
@can-anyscale can-anyscale changed the title Can byod py39 [ci][byod] support python 3.9 Jun 22, 2023
@can-anyscale can-anyscale marked this pull request as ready for review June 22, 2023 22:46
@can-anyscale can-anyscale requested a review from a team as a code owner June 22, 2023 22:46


def test_get_anyscale_byod_image():
os.environ["BUILDKITE_BRANCH"] = "master"
os.environ["BUILDKITE_COMMIT"] = "1234567890"
assert (
_stub_test({}).get_anyscale_byod_image()
_stub_test({"python": "3.7", "cluster": {"byod": {}}}).get_anyscale_byod_image()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this "3.7"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be any version, mostly so that I don't have to change the output

@can-anyscale can-anyscale added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 23, 2023
Signed-off-by: can <can@anyscale.com>
Signed-off-by: can <can@anyscale.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants