Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] [Serve Replica] Making the log link works #36659

Merged
merged 7 commits into from
Jun 30, 2023
Merged

[UI] [Serve Replica] Making the log link works #36659

merged 7 commits into from
Jun 30, 2023

Conversation

chaowanggg
Copy link
Contributor

@chaowanggg chaowanggg commented Jun 21, 2023 •
edited
Loading

Why are these changes needed?

  1. Perviously, the log link could not jump to the task page.
  2. Now, add a React Route in ServeReplicaDetailPage to make the log link jumping works
Screen.Recording.2023-06-29.at.4.50.55.PM.mov

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@chaowanggg chaowanggg requested a review from alanwguo June 21, 2023 19:42
@chaowanggg chaowanggg requested a review from scottsun94 June 21, 2023 20:51
@scottsun94
Copy link
Contributor

LGTM. Thanks!

@chaowanggg chaowanggg marked this pull request as draft June 29, 2023 22:51
@chaowanggg chaowanggg marked this pull request as ready for review June 29, 2023 23:53
alanwguo
alanwguo approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@alanwguo alanwguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chaowanggg
Copy link
Contributor Author

@scottsun94
The link of serveReplica ID also works

Screen.Recording.2023-06-29.at.5.46.13.PM.mov

@scottsun94
Copy link
Contributor

Awesome!

@chaowanggg chaowanggg mentioned this pull request Jun 30, 2023
Closed
@rkooo567 rkooo567 merged commit 00d4461 into ray-project:master Jun 30, 2023
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@chaowanggg @arvind-chandra
[UI] [Serve Replica] Making the log link works (ray-project#36659)
d139ffa 
Perviously, the log link could not jump to the task page.
Now, add a React Route in ServeReplicaDetailPage to make the log link jumping works

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanwguo alanwguo alanwguo approved these changes

@scottsun94 scottsun94 Awaiting requested review from scottsun94

Assignees

@rkooo567 rkooo567

@chaowanggg chaowanggg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaowanggg @scottsun94 @alanwguo @rkooo567