[release/air] Fix air_example_gptj_deepspeed_fine_tuning.gce failing...
#36562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to pull model from a public s3 bucket (ray-project#36276) This PR fixes the `air_example_gptj_deepspeed_fine_tuning.gce` release test. It was failing due to our GCE nodes not having an AWS credentials file. This is not needed due to the s3 bucket being public, so we just pass a `--no-sign-request` flag to use AWS cli as an anonymous user. This also removes the `--quiet` flag since this cell is not shown to users anyways, and it'd help us catch some aws cli error in the future. This PR also fixes the recent `datasets==2.13.0` breaking `TransformersTrainer`. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
matthewdeng
reviewed
Jun 20, 2023
|
+1 to just include docs fixes |
added 2 commits
June 21, 2023 09:52
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
|
Updated! PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to pull model from a public s3 bucket (#36276)
This PR fixes the
air_example_gptj_deepspeed_fine_tuning.gcerelease test. It was failing due to our GCE nodes not having an AWS credentials file. This is not needed due to the s3 bucket being public, so we just pass a--no-sign-requestflag to use AWS cli as an anonymous user. This also removes the--quietflag since this cell is not shown to users anyways, and it'd help us catch some aws cli error in the future.This PR also fixes the recent
datasets==2.13.0breakingTransformersTrainer.Why are these changes needed?
Related issue number
Closes #36507
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.