Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mac] Skip test_cli.py::test_ray_start as it's currently flaky #36496

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Kai Fricke <kai@anyscale.com>
@ollie-iterators
Copy link

I'm wondering if this means that #36149 is not working because the PR says that it should be moving tests that consistently fail to a jailed state and not run them.

@krfricke krfricke marked this pull request as ready for review June 16, 2023 13:36
@krfricke krfricke requested a review from matthewdeng June 16, 2023 13:36
@krfricke krfricke merged commit 33eb469 into ray-project:master Jun 16, 2023
@krfricke krfricke deleted the mac/skip-cli branch June 16, 2023 18:14
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…roject#36496)

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants