Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autoscaler] monitor: do not call logger.Exception in sig handler #36491

Merged
merged 1 commit into from
Jun 16, 2023
Merged

[Autoscaler] monitor: do not call logger.Exception in sig handler #36491

merged 1 commit into from
Jun 16, 2023

Conversation

aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Jun 16, 2023 •
edited
Loading

Otherwise, it will print the following message on normal exiting:

2023-06-16 06:33:59,740	ERROR monitor.py:551 -- Error in monitor loop
NoneType: None

Fix #33747

@pcmoritz
Copy link
Contributor

pcmoritz commented Jun 16, 2023 •
edited
Loading

Thank you so much for fixing this ❤️ I have seen this so many times and was always confused what was going on. This makes so much sense.

@aslonnie
monitor: do not call logger.Exception in sig handler
dcbb040 
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
@aslonnie aslonnie force-pushed the lonnie-0615-monitorexit branch from b7fcfbc to dcbb040 Compare June 16, 2023 08:30
@cadedaniel
Copy link
Member

cadedaniel commented Jun 16, 2023 •
edited
Loading

Ah nice fix! Can we mark this as Closing #33747 ?

Also nit: prefix PR title with [Autoscaler]

@cadedaniel cadedaniel changed the title monitor: do not call logger.Exception in sig handler [Autoscaler] monitor: do not call logger.Exception in sig handler Jun 16, 2023
@aslonnie
Copy link
Collaborator Author

Also nit: prefix PR title with [Autoscaler]

technically autoscaler is inside the monitor (I think), but I do not really mind about the terms.

@pcmoritz pcmoritz merged commit 1aa3dba into master Jun 16, 2023
@pcmoritz pcmoritz deleted the lonnie-0615-monitorexit branch June 16, 2023 17:45
@cadedaniel
Copy link
Member

technically autoscaler is inside the monitor (I think), but I do not really mind about the terms.

ok. I meant put the category (monitor or autoscaler) in brackets, this makes it easier to do release logs 😄

@aslonnie
Copy link
Collaborator Author

technically autoscaler is inside the monitor (I think), but I do not really mind about the terms.

ok. I meant put the category (monitor or autoscaler) in brackets, this makes it easier to do release logs 😄

got it! brackets!

@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@aslonnie @arvind-chandra
[Autoscaler] Monitor: do not call logger.Exception in sig handler (ra…
fbfcf07 
…y-project#36491)

Otherwise, it will print the following message on normal exiting:

```
2023-06-16 06:33:59,740	ERROR monitor.py:551 -- Error in monitor loop
NoneType: None
```

Fix ray-project#33747

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

@cadedaniel cadedaniel cadedaniel approved these changes

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman

@ericl ericl Awaiting requested review from ericl

Assignees

@ericl ericl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Autoscaler] Autoscaler log has error, but only prints NoneType: None
4 participants
@aslonnie @pcmoritz @cadedaniel @ericl