Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test][Train] Migrate Ray Train code-block to testcode. #36483

Merged
merged 20 commits into from
Jun 30, 2023
Merged

[Test][Train] Migrate Ray Train code-block to testcode. #36483

merged 20 commits into from
Jun 30, 2023

Conversation

woshiyyya
Copy link
Member

@woshiyyya woshiyyya commented Jun 16, 2023 •
edited
Loading

Why are these changes needed?

This PR aims to make the code-blocks in docstring testable.

File Number priority
✅ base_trainer.py 4 P0
✅ torch_trainer.py 1 P0
✅ accelerate_trainer.py 1 P0
✅ transformers_trainer.py 1 P0
✅ lightning_trainer.py 2 P0
✅ data_parallel_trainer.py 6 P1
✅ sklearn_trainer.py 1 P1
✅ lightning_checkpoint.py 1 P1
✅ xgboost_trainer.py 1 P1
✅ lightgbm_trainer.py 1 P2
✅ lightning_predictor.py 1 P2
✅ tensorflow_trainer.py 3 P2
✅ tensorflow_predictor.py 1 P3
✅ rl_trainer.py 2 (skipped 1 that requires dataset) P3
✅ horovod_trainer.py 4 (skipped 1 that requires setup horovod env) P3
Total 31

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

woshiyyya added 15 commits June 15, 2023 17:02
@woshiyyya
finish base_trainer.py
cd34944 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
finish lightning_trainer.py
d8ef0b5 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
fixed torch_trainer.py
ed941a5 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
finish transformers_trainer.py
767684b 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
add max_steps in HF TrainingArguments
91f3d3e 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
finish accelearte_trainer
e8f9c90 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
Merge remote-tracking branch 'upstream/master' into train/improve_doc…
2caa7b5 
…tests
@woshiyyya
finish data_parallel_trainer
5aa8cc8 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
add testoutput hide
81fc4e1 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
finish sklearn trainer
76a948a 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
finish xgb, lgb trainer
41b0891 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
fix tensorflow + partial horovod&rl trainer
61ffd0d 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
finish lightning ckpt and predictor
7b7e778 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
skip rl_trainer and horovod_trainer
cc3327c 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
Merge remote-tracking branch 'upstream/master' into train/improve_doc…
9537ec0 
…tests
@woshiyyya woshiyyya marked this pull request as ready for review June 27, 2023 17:03
@woshiyyya woshiyyya changed the title [Test][Train] Improve Ray Train Doctests. [Test][Train] Migrate Ray Train docstrings code-block to testcode. Jun 27, 2023
@woshiyyya woshiyyya changed the title [Test][Train] Migrate Ray Train docstrings code-block to testcode. [Test][Train] Migrate Ray Train code-block to testcode. Jun 27, 2023
woshiyyya added 3 commits June 27, 2023 11:38
@woshiyyya
change to size=large
9d844d6 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
fix by skipping test-output
b01eeb7 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
Merge remote-tracking branch 'upstream/master' into train/improve_doc…
b9cdeba 
…tests
@woshiyyya woshiyyya requested a review from matthewdeng June 29, 2023 00:39
bveeramani
bveeramani approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leo Clap

@woshiyyya
unquote ...
2007667 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
bveeramani
bveeramani reviewed Jun 29, 2023
View reviewed changes
@woshiyyya
fix xgboost doctest
80ab593 
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@matthewdeng matthewdeng merged commit 31878b3 into ray-project:master Jun 30, 2023
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@woshiyyya @arvind-chandra
[Test][Train] Migrate Ray Train code-block to testcode. (ray-proj…
470f6ec 
…ect#36483)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bveeramani bveeramani bveeramani approved these changes

@matthewdeng matthewdeng matthewdeng approved these changes

Assignees

@bveeramani bveeramani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woshiyyya @matthewdeng @bveeramani