Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Clean up ray.data.aggregate namespace #36468

Merged
merged 3 commits into from
Jun 15, 2023
Merged

[Data] Clean up ray.data.aggregate namespace #36468

merged 3 commits into from
Jun 15, 2023

Conversation

pcmoritz
Copy link
Contributor

Why are these changes needed?

This cleans up code completion for the ray.data.aggregate namespace (I ran into this while using ray.data):

Before:
Screen Shot 2023-06-15 at 1 09 45 PM

After:
Screen Shot 2023-06-15 at 1 10 39 PM

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@pcmoritz pcmoritz merged commit 5d772c6 into ray-project:master Jun 15, 2023
@pcmoritz pcmoritz deleted the aggregate-cleanup branch June 15, 2023 23:47
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@pcmoritz @arvind-chandra
[Data] Clean up ray.data.aggregate namespace (ray-project#36468)
2fa75c9 
This cleans up code completion for the ray.data.aggregate namespace (I ran into this while using ray.data):

Before:
<img width="712" alt="Screen Shot 2023-06-15 at 1 09 45 PM" src="https://github.com/ray-project/ray/assets/113316/38313256-735b-4ae1-b8f0-78c5729683d6">

After:
<img width="498" alt="Screen Shot 2023-06-15 at 1 10 39 PM" src="https://github.com/ray-project/ray/assets/113316/01e4cc8a-36ed-466e-8b4c-83b003e9994a">

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@c21 c21 Awaiting requested review from c21

@scottjlee scottjlee Awaiting requested review from scottjlee

@bveeramani bveeramani Awaiting requested review from bveeramani

@raulchen raulchen Awaiting requested review from raulchen

Assignees

@amogkam amogkam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcmoritz @amogkam