-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][core] Add more visbility into state api stress test #36465
Merged
jjyao
merged 5 commits into
ray-project:master
from
rickyyx:pr-test-update-scale-test-api
Jun 16, 2023
Merged
[ci][core] Add more visbility into state api stress test #36465
jjyao
merged 5 commits into
ray-project:master
from
rickyyx:pr-test-update-scale-test-api
Jun 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyao
approved these changes
Jun 15, 2023
Signed-off-by: rickyyx <rickyx@anyscale.com>
aslonnie
reviewed
Jun 15, 2023
rickyyx
commented
Jun 15, 2023
@@ -165,7 +170,7 @@ def exit(self): | |||
|
|||
def test_many_objects(num_objects, num_actors): | |||
if num_objects == 0: | |||
print("Skipping test with no objects") | |||
logger.info("Skipping test with no objects") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we have timestamps.
Running a test here: https://buildkite.com/ray-project/release-tests-pr/builds/42381 |
…est-update-scale-test-api
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…#36465) The workload seems to be stuck while creating objects - it's not part of what the test aims to test. I wonder if there's some regression or new issues that's orthogonal to what this test is doing. I am also unstabling this test for now while I look into the failures. (The test has become unstable recently, with failures that are not relevant to the state API) Signed-off-by: rickyyx <rickyx@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The workload seems to be stuck while creating objects - it's not part of what the test aims to test.
I wonder if there's some regression or new issues that's orthogonal to what this test is doing.
I am also unstabling this test for now while I look into the failures. (The test has become unstable recently, with failures that are not relevant to the state API)
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.