Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][core] Add more visbility into state api stress test #36465

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Jun 15, 2023

Why are these changes needed?

The workload seems to be stuck while creating objects - it's not part of what the test aims to test.

I wonder if there's some regression or new issues that's orthogonal to what this test is doing.

I am also unstabling this test for now while I look into the failures. (The test has become unstable recently, with failures that are not relevant to the state API)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

rickyyx added 2 commits June 15, 2023 19:11
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx requested a review from a team as a code owner June 15, 2023 19:21
release/release_tests.yaml Show resolved Hide resolved
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
@@ -165,7 +170,7 @@ def exit(self):

def test_many_objects(num_objects, num_actors):
if num_objects == 0:
print("Skipping test with no objects")
logger.info("Skipping test with no objects")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we have timestamps.

@rickyyx
Copy link
Contributor Author

rickyyx commented Jun 15, 2023

@rickyyx
Copy link
Contributor Author

rickyyx commented Jun 16, 2023

@jjyao jjyao merged commit a799682 into ray-project:master Jun 16, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…#36465)

The workload seems to be stuck while creating objects - it's not part of what the test aims to test.

I wonder if there's some regression or new issues that's orthogonal to what this test is doing.

I am also unstabling this test for now while I look into the failures. (The test has become unstable recently, with failures that are not relevant to the state API)

Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants