Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][byod/ml][2] migrate the rest of ml tests to byod #36434

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jun 14, 2023

Why are these changes needed?

Migrate the rest of ml tests to byod, which is a more reliable way of running release tests

Checks

@can-anyscale can-anyscale force-pushed the can-byod-ml-tests-02 branch 6 times, most recently from 78c7349 to 9cfd46e Compare June 18, 2023 02:12
@can-anyscale can-anyscale changed the base branch from master to can-byod-ml-tests June 18, 2023 02:13
@can-anyscale can-anyscale force-pushed the can-byod-ml-tests-02 branch 17 times, most recently from 0fabbb3 to 859710c Compare June 19, 2023 04:59
@can-anyscale can-anyscale changed the title Can byod ml tests 02 [ci][byod/ml][2] migrate the rest of ml tests to byod Jun 19, 2023
@can-anyscale can-anyscale force-pushed the can-byod-ml-tests-02 branch from 859710c to 2cc86d1 Compare June 19, 2023 15:04
@can-anyscale can-anyscale marked this pull request as ready for review June 19, 2023 15:06
@can-anyscale can-anyscale requested a review from a team as a June 19, 2023 15:06
@can-anyscale can-anyscale force-pushed the can-byod-ml-tests branch 2 times, most recently from 8fd4f69 to dd98902 Compare June 19, 2023 15:23
@can-anyscale can-anyscale force-pushed the can-byod-ml-tests-02 branch from 2cc86d1 to 4613fc0 Compare June 19, 2023 15:25

set -exo pipefail

HOROVOD_WITH_GLOO=1 HOROVOD_WITHOUT_MPI=1 HOROVOD_WITHOUT_TENSORFLOW=1 HOROVOD_WITHOUT_MXNET=1 HOROVOD_WITH_PYTORCH=1 pip3 install -U git+https://github.com/horovod/horovod.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could you add one or two slashes to make the line width smaller? maybe with in 80 chars?

@can-anyscale can-anyscale force-pushed the can-byod-ml-tests-02 branch from 4613fc0 to 141f10b Compare June 21, 2023 23:47
@can-anyscale can-anyscale added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 21, 2023
@can-anyscale can-anyscale force-pushed the can-byod-ml-tests-02 branch 2 times, most recently from 70ed167 to ad6a51e Compare June 21, 2023 23:56
Base automatically changed from can-byod-ml-tests to master June 21, 2023 23:58
Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale force-pushed the can-byod-ml-tests-02 branch from ad6a51e to 1d01bb7 Compare June 21, 2023 23:59
@richardliaw richardliaw merged commit 7a7f8e0 into master Jun 22, 2023
@richardliaw richardliaw deleted the can-byod-ml-tests-02 branch June 22, 2023 00:09
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: can <can@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants