Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Unskip test_autoscaler_shutdown_node_http_everynode #36420

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[Serve] Unskip test_autoscaler_shutdown_node_http_everynode #36420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions python/ray/serve/tests/test_standalone3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
wait_for_condition,
SignalActor,
)
from ray._private.ray_constants import gcs_actor_scheduling_enabled
from ray.cluster_utils import AutoscalingCluster
from ray.exceptions import RayActorError
from ray.serve._private.constants import (
Expand Down Expand Up @@ -326,15 +325,6 @@ def f(do_crash: bool = False):
serve.shutdown()


@pytest.mark.skipif(
gcs_actor_scheduling_enabled(),
reason="Raylet-based scheduler favors (http proxy) actors' owner "
+ "nodes (the head one), so the `EveryNode` option is actually not "
+ "enforced. Besides, the second http proxy does not die with the "
+ "placeholder (happens to both schedulers), so gcs-based scheduler (which "
+ "may collocate the second http proxy and the place holder) "
+ "can not shutdown the worker node.",
)
def test_autoscaler_shutdown_node_http_everynode(
shutdown_ray, call_ray_stop_only # noqa: F811
):
Expand Down