Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix Data examples TOC and rendering #36404

Merged
merged 3 commits into from
Jun 14, 2023
Merged

[Docs] Fix Data examples TOC and rendering #36404

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad78261
update toc
amogkam Jun 14, 2023
261cd83
retry
amogkam Jun 14, 2023
5a094fb
update
amogkam Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/_toc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ parts:
- file: data/getting-started
- file: data/key-concepts
- file: data/user-guide
- file: data/examples
- file: data/data_examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- file: data/data_examples
- file: data/data_examples
title: Examples

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you open to keeping the name the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name isn't changed in this PR. It's still being pulled from the title of data_examples.rst

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can set it with that title line, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not provided, it will default to the title in the rst file

- file: data/faq
- file: data/api/api

Expand Down