Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Add node ID to replica started log #36385

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[serve] Add node ID to replica started log #36385

merged 1 commit into from
Jun 14, 2023

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Jun 13, 2023

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes
fix
d5461f6 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested a review from a team June 13, 2023 21:03
GeneDer
GeneDer approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

zcin
zcin approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@zcin zcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speedy!

@edoakes edoakes merged commit 87f0c97 into ray-project:master Jun 14, 2023
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@edoakes @arvind-chandra
[serve] Add node ID to replica started log (ray-project#36385)
5d3f537 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeneDer GeneDer GeneDer approved these changes

@zcin zcin zcin approved these changes

@shrekris-anyscale shrekris-anyscale shrekris-anyscale approved these changes

Assignees

@zcin zcin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edoakes @GeneDer @zcin @shrekris-anyscale