[Docs] Fix :book: Doctest (GPU)
#36383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
:skipif: True with :options: +MOCK:book: Doctest (GPU)
angelinalg
approved these changes
Jun 13, 2023
|
there is still a doc test failure. related? https://buildkite.com/ray-project/oss-ci-build-pr/builds/25377#0188b64d-bf3b-4ec2-8ce8-6df2a36cabc6 |
@raulchen That's for the CPU doctest (this PR fixes the GPU doctest), and that's a known flaky example: #36384. |
raulchen
approved these changes
Jun 13, 2023
|
is this ready for merge? there is a dependency not merged yet. |
Both PRs are ready to merge. Could you first merge #36359 and then this PR? |
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
ray-project#36206 replaced `:options: +MOCK` with `:skipif: True` in `batch_inference.rst`. As a result, doctest is failing: https://buildkite.com/ray-project/oss-ci-build-pr/builds/25117#0188a1b9-31f9-47df-89cb-f508a90685d9. This PR reverts the change. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Why are these changes needed?
#36206 replaced
:options: +MOCKwith:skipif: Trueinbatch_inference.rst. As a result, doctest is failing: https://buildkite.com/ray-project/oss-ci-build-pr/builds/25117#0188a1b9-31f9-47df-89cb-f508a90685d9.This PR reverts the change.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.