-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][byod] migrate all data tests to byod #36344
Conversation
1a18255
to
75c3f65
Compare
75c3f65
to
ad3d746
Compare
On CI, release tests that fail are already fail on master |
ca8f8d4
to
dc8817e
Compare
If byod is disabled on pull requests, how are you testing moving data tests to byod? |
we have means to run tests with wheels and containers that are already built. |
dc8817e
to
1a01a19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone from Data team review this? @amogkam @bveeramani @raulchen @scottjlee
1a01a19
to
924c1f8
Compare
924c1f8
to
7b7ad84
Compare
Signed-off-by: can <can@anyscale.com>
7b7ad84
to
1f65087
Compare
data folks, @amogkam @bveeramani @raulchen @scottjlee, if you all don't have a strong opinion, I'll merge this PR in sometimes tomorrow on the merit that tests pass after this change. Thankkks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! qq, I saw these tests with the label team: data
did not have the byod config. Are these to be excluded? (e.g. for being chaos / unstable tests)
pipelined_training_50_gb
dataset_shuffle_random_shuffle_1tb
dataset_shuffle_push_based_random_shuffle_100tb
chaos_dask_on_ray_large_scale_test_no_spilling
chaos_dask_on_ray_large_scale_test_spilling
chaos_pipelined_ingestion_1500_gb_15_windows
chaos_dataset_shuffle_push_based_sort_1tb
@scottjlee: thanks for reviewing Scott. Yesss, some of the tests are currently failing on master so I exclude them until they get fixed first |
Signed-off-by: can <can@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Why are these changes needed?
Release test infra now support running tests using anyscale byod, which is a more reliable way of testing.
Migrate all/most data tests to byod
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.