Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][byod] migrate all data tests to byod #36344

Merged
merged 1 commit into from
Jun 16, 2023
Merged

[ci][byod] migrate all data tests to byod #36344

merged 1 commit into from
Jun 16, 2023

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jun 12, 2023

Why are these changes needed?

Release test infra now support running tests using anyscale byod, which is a more reliable way of testing.

Migrate all/most data tests to byod

Checks

@can-anyscale can-anyscale force-pushed the can-byod-more branch 9 times, most recently from 1a18255 to 75c3f65 Compare June 13, 2023 15:29
@can-anyscale can-anyscale changed the base branch from master to can-avoid-update June 13, 2023 15:29
@can-anyscale can-anyscale marked this pull request as ready for review June 13, 2023 16:56
@can-anyscale can-anyscale requested a review from a team as a code owner June 13, 2023 16:56
@can-anyscale
Copy link
Collaborator Author

On CI, release tests that fail are already fail on master

@ollie-iterators
Copy link

If byod is disabled on pull requests, how are you testing moving data tests to byod?

@aslonnie
Copy link
Collaborator

If byod is disabled on pull requests, how are you testing moving data tests to byod?

we have means to run tests with wheels and containers that are already built.

@aslonnie
Copy link
Collaborator


via Rota 29 on GIPHY

Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone from Data team review this? @amogkam @bveeramani @raulchen @scottjlee

release/release_tests.yaml Show resolved Hide resolved
Signed-off-by: can <can@anyscale.com>
@can-anyscale
Copy link
Collaborator Author

data folks, @amogkam @bveeramani @raulchen @scottjlee, if you all don't have a strong opinion, I'll merge this PR in sometimes tomorrow on the merit that tests pass after this change. Thankkks

Copy link
Contributor

@scottjlee scottjlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! qq, I saw these tests with the label team: data did not have the byod config. Are these to be excluded? (e.g. for being chaos / unstable tests)

pipelined_training_50_gb
dataset_shuffle_random_shuffle_1tb
dataset_shuffle_push_based_random_shuffle_100tb
chaos_dask_on_ray_large_scale_test_no_spilling
chaos_dask_on_ray_large_scale_test_spilling
chaos_pipelined_ingestion_1500_gb_15_windows
chaos_dataset_shuffle_push_based_sort_1tb

@can-anyscale
Copy link
Collaborator Author

@scottjlee: thanks for reviewing Scott. Yesss, some of the tests are currently failing on master so I exclude them until they get fixed first

@matthewdeng matthewdeng merged commit 741388e into master Jun 16, 2023
@matthewdeng matthewdeng deleted the can-byod-more branch June 16, 2023 22:45
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: can <can@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants