Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci][py11] support docker image build for x86 #36223

Merged
merged 1 commit into from
Jun 23, 2023
Merged

[ci][py11] support docker image build for x86 #36223

merged 1 commit into from
Jun 23, 2023

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jun 8, 2023 •
edited
Loading

Why are these changes needed?

Support Linux cpu docker image build for py11

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • Testing Strategy
    • Unit tests

@can-anyscale can-anyscale force-pushed the can-docker-py11 branch 7 times, most recently from 391ee73 to 90b5a8e Compare June 14, 2023 22:56
@can-anyscale can-anyscale force-pushed the can-docker-py11 branch 23 times, most recently from 9d4b4fd to d71e2b7 Compare June 19, 2023 05:23
@can-anyscale can-anyscale force-pushed the can-docker-py11 branch 3 times, most recently from b0d1599 to bc8a374 Compare June 20, 2023 05:14
@can-anyscale can-anyscale requested a review from aslonnie June 20, 2023 14:18
rickyyx
rickyyx approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

But I will wait for opinions from the CI team for a better stamp.

docker/base-deps/Dockerfile Outdated Show resolved Hide resolved
@can-anyscale
Copy link
Collaborator Author

I think I still need an approval from @aslonnie or @krfricke as a code owner. Thankkks

@can-anyscale can-anyscale changed the title [ci][py11] support docker image build [ci][py11] support docker image build for x86 Jun 20, 2023
aslonnie
aslonnie reviewed Jun 21, 2023
View reviewed changes
docker/base-deps/Dockerfile Outdated Show resolved Hide resolved
docker/base-deps/Dockerfile Outdated Show resolved Hide resolved
docker/base-deps/Dockerfile Outdated Show resolved Hide resolved
docker/base-deps/Dockerfile Outdated Show resolved Hide resolved
@can-anyscale can-anyscale force-pushed the can-docker-py11 branch 8 times, most recently from c4ac061 to 7bbb49a Compare June 22, 2023 22:15
@can-anyscale
Support docker build for 3.11
f3b5051 
Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale requested a review from aslonnie June 22, 2023 23:52
aslonnie
aslonnie approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krfricke krfricke merged commit 0adf1ad into master Jun 23, 2023
@krfricke krfricke deleted the can-docker-py11 branch June 23, 2023 13:45
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@can-anyscale @arvind-chandra
[ci/pye11] Support docker build for 3.11 (ray-project#36223)
87e1ef0 
Support Linux cpu docker image build for py11

Signed-off-by: can <can@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyyx rickyyx rickyyx approved these changes

@krfricke krfricke krfricke approved these changes

@aslonnie aslonnie aslonnie approved these changes

Assignees

@rickyyx rickyyx

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@can-anyscale @aslonnie @rickyyx @krfricke